[bug fix] Make sure we sleep for positive duration #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klautcomputing
approved these changes
Apr 6, 2018
|
I got the tests to pass but one of the test was very flakey see #274 |
KnVerey
approved these changes
Apr 6, 2018
Update changelog
dturn
force-pushed
the
bug-fix-sleep
branch
2 times, most recently
from
70855cf
to
04dbb60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to calling
Time.now.utctwice, it was possible for sleep to receive a negative value. Fix that by callingTime.now.utconce and ensure the sleep duration is> 0.Fixes: #272 (comment)
Attempted to improve: #274