Removes special treatment of GCP authentication #465
Conversation
| end | ||
|
|
||
| def teardown | ||
| WebMock.allow_net_connect! | ||
| end | ||
|
|
||
| def test_auth_use_default_gcp_success |
There was a problem hiding this comment.
Is this test invalid now, or are you removing it because we no longer own the code that makes it work?
There was a problem hiding this comment.
I removed it because it’s no longer our responsibility, the same way we don’t have test coverage for OIDC for example.
benlangfeld
force-pushed
the
google-auth
branch
from
7fe393f
to
fcef44e
Compare
There was a problem hiding this comment.
I had to push this as a commit on the Shopify copy of the repo (here) to use our test mechanism, but was then able to run the test without issue. Employees can confirm here that the test deploy ran without issue based on the correct sha: Using kubernetes-deploy 0.26.4 from https://github.com/Shopify/kubernetes-deploy.git (at 54f7cd2@54f7cd2)
|
@timothysmith0609 can you please 👀 this? |
|
The diff makes sense to me, in the end we've just moved the same logic out to the kubeclient gem. Since the test run has passed I feel pretty confident. |
What are you trying to accomplish with this PR?
Simplify code related to GCP authentication.
How is this accomplished?
Upgrading to a version of kubeclient which deals with GCP auth natively: ManageIQ/kubeclient#394 (comment)
What could go wrong?
GCP auth could break. I'm not in a position to test it, but our unit tests were passing before they were removed.