Allow for yaml aliases to be loaded using YAML.safe_load #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we want this so added a test to prevent a future regression, I'll leave the approval to people with more context. |
dturn
approved these changes
Jul 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish with this PR?
As of #504 and
0.26.5, YAML aliases no longer load and instead throw aPsych::BadAlias.This PR reenabled YAML aliases based on the Psych docs:
https://ruby-doc.org/stdlib-2.1.0/libdoc/psych/rdoc/Psych.html#method-c-safe_load
How is this accomplished?
Changes
YAML.safe_loadWhat could go wrong?
Matches the YAML alias behaviour pre-
0.26.5, so I'm hoping this is pretty safe. It looks like the dropping of YAML alias support wasn't intentional.