Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces changes that allow one to provide a partial custom LHCI config that gets merged with the default one provided in
entrypoint.sh
file and fixes #20.It's a bit of a wip, but I wanted to get some feedback first. Things that are missing:
.lighthouserc.yml
)README.md
fileDockerfile
to use the updated base image, once it's publishedIt's also possible to overwrite some of the other inputs (e.g. LHCI scores) with this config, which might be a bit confusing.
I tested it with
act
and it works. I also pushed the new base Docker image that includesyq
toszimek/lighthouse-ci-action:1.1.0
.