Lighthouse looking for password somewhere on clean Dawn theme #33
Comments
|
Hey @Avex-Dev I've worked out how to fix this... If your store isn't password protected (via Shopify Admin) - don't set the 'SHOP_PASSWORD' secret in your repo, this will then bypass the password page check in lighthouse check. It would also help if Shopify updated their documentation to explain this! The below explains why (found in entrypoint.sh file within this repo)
|
|
Hey guys, I'm also facing the same issue. In my case, I have a development store, and it's password-protected. I've added the correct password, but I'm still getting the following error log. Has this issue been resolved by any chance? or this is only for stores that are not having password protection ? 🤔 |
|
Bumping this because we starting seeing this quite literally out of the blue. We've had this set up and working without issue for weeks. Then today one minute it was working, the next, every single push gets the same result: |
|
Also seeing this on a development shop that has a store password |
|
This error is shown when there isn't a form with an input of type password on your theme. e.g. Did any of you change it? Did the platform change it? The above code made the assumption that this would be there on the password page. |
|
Hey @charlespwd , thanks for your reply! What you're saying makes total sense since the error was essentially saying it couldn't find To test this I opened an incognito window, went to the myshopify url for the dev store in question, and immediately saw the password login form. The url even had Thanks again for your reply! |
|
@charlespwd Can also confirm that my store has a password with the proper elements:
and
|
|
I see the same on the rendered page as @eddysims. In the code, however, I don't see a place where a change can be made to the form because it seems to be absent — or rather inside the <body class="password gradient">
<a class="skip-to-content-link button visually-hidden" href="#MainContent">
{{ 'accessibility.skip_to_text' | t }}
</a>
{% section 'main-password-header' %}
<main id="MainContent" class="password-main">
{{ content_for_layout }}
</main>
<footer>
{% section 'main-password-footer' %}
</footer>
<ul hidden>
<li id="a11y-new-window-message">{{ 'accessibility.link_messages.new_window' | t }}</li>
</ul>
</body> |
|
Not sure if anyone else has seen a change today, but just as suddenly and inexplicably as this stopped working last week it started working again this morning. We haven't made any changes that I can imagine would impact this at all — certainly no changes to the password form since it's not something we have access to. Either way, just really grateful to see that little green checkmark again 😆 
|
|
Ah I think it might be related to the Shopify CLI problem we were having. 5.80.0 introduced a regression on Thanks for updating the issue. That must have been the root cause. I was really scratching my head on that one and didn't have capacity to look into it. |
|
No worries at all @charlespwd , and thanks for the additional info here! I appreciate you closing the loop for us! |
I am working right off a download of a clean Dawn theme following https://shopify.dev/themes/getting-started/create which has a password page, however, the password is not active, and I am getting the following error:
Originally posted by @Avex-Dev in #15 (comment)
The text was updated successfully, but these errors were encountered: