Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update shopify/lighthouse-ci-action to rely on Shopify CLI 3.x + Theme Access app #51

Open
karreiro opened this issue Oct 24, 2022 · 4 comments
Labels
good first issue Good for newcomers

Comments

@karreiro
Copy link
Contributor

karreiro commented Oct 24, 2022

Currently, the Lighthouse CI GH action relies on Shopify CLI 2.x:
https://github.com/Shopify/lighthouse-ci-action/blob/main/entrypoint.sh#L130

This issues aims to update it to rely on the Theme Access app and Shopify CLI 3.x.

⚠️ This issue impacts documentation: https://shopify.dev/themes/tools/lighthouse-ci

@knjshimi
Copy link

knjshimi commented Apr 9, 2023

Hi @karreiro, just checking if this is still on Shopify plans for the near future. Thank you!

@karreiro
Copy link
Contributor Author

Hi, @kenji-twp, thanks for reaching out. Yes, this is definitely on our plans, still we don't have a specific timeframe at the moment.

@knjshimi
Copy link

Thanks @karreiro! Just to confirm, is the current version of the shopify lighthouse CI action working despite of it using Shopify CLI 2? If so, will it continue to work when v2 sunsets?

@satish-bjss
Copy link

Why do we hardcode ruby version rather install within Shopify CLI as an internal dependency OR allow to apply

-use: ruby/setup-ruby@v1 with: ruby-version: x.x bundler: 'latest'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
4 participants