[Icon] Add support for emphasis and text tones and migrated color custom properties (#10722)

### WHY are these changes introduced?

Resolves #10486.
Adds support for net new tones on `Icon` component `tone` prop.

### WHAT is this pull request doing?

Adds `emphasis` and `text` tones to `Icon`. 
Migrates `primary` and `subdued` color custom properties.

### How to 🎩


[Storybook](https://5d559397bae39100201eedc1-sbgcrlbgjk.chromatic.com/?path=/story/all-components-icon--colored)

🖥 [Local development
instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development)
🗒 [General tophatting
guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md)
📄 [Changelog
guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)

### 🎩 checklist

- [x] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [x] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [ ] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide

Author: laurkim

.changeset/five-cooks-fly.md

@@ -0,0 +1,5 @@
+---
+'@shopify/polaris': minor
+---
+
+Added support for `emphasis` and `text` tones on `Icon` and migrated `primary` and `subdued` tone color tokens

polaris-react/src/components/Icon/Icon.scss

@@ -18,7 +18,7 @@
 }
 
 .toneSubdued svg {
-  fill: var(--p-color-icon-subdued);
+  fill: var(--p-color-icon-secondary);
 }
 
 .toneCaution svg {
@@ -46,13 +46,45 @@
 }
 
 .tonePrimary svg {
-  fill: var(--p-color-icon-primary);
+  fill: var(--p-color-icon-brand);
+}
+
+.toneEmphasis svg {
+  fill: var(--p-color-icon-emphasis);
 }
 
 .toneMagic svg {
   fill: var(--p-color-icon-magic);
 }
 
+.toneTextCaution svg {
+  fill: var(--p-color-text-caution);
+}
+
+.toneTextWarning svg {
+  fill: var(--p-color-text-warning);
+}
+
+.toneTextCritical svg {
+  fill: var(--p-color-text-critical);
+}
+
+.toneTextInfo svg {
+  fill: var(--p-color-text-info);
+}
+
+.toneTextPrimary svg {
+  fill: var(--p-color-text-brand);
+}
+
+.toneTextSuccess svg {
+  fill: var(--p-color-text-success);
+}
+
+.toneTextMagic svg {
+  fill: var(--p-color-text-magic);
+}
+
 .Svg,
 .Img {
   position: relative;

polaris-react/src/components/Icon/Icon.stories.tsx

@@ -1,6 +1,6 @@
 import React from 'react';
 import type {ComponentMeta} from '@storybook/react';
-import {Icon} from '@shopify/polaris';
+import {Icon, Text, BlockStack} from '@shopify/polaris';
 import {CirclePlusMinor} from '@shopify/polaris-icons';
 
 export default {
@@ -13,17 +13,76 @@ export function Default() {
 
 export function Colored() {
   return (
-    <div>
+    <BlockStack gap="2">
+      <Text as="p" variant="bodyMd" alignment="center">
+        Base tone
+      </Text>
       <Icon source={CirclePlusMinor} tone="base" />
+      <Text as="p" variant="bodyMd" alignment="center">
+        Subdued tone
+      </Text>
       <Icon source={CirclePlusMinor} tone="subdued" />
+      <Text as="p" variant="bodyMd" alignment="center">
+        Primary tone
+      </Text>
       <Icon source={CirclePlusMinor} tone="primary" />
+      <Text as="p" variant="bodyMd" alignment="center">
+        Info tone
+      </Text>
       <Icon source={CirclePlusMinor} tone="info" />
+      <Text as="p" variant="bodyMd" alignment="center">
+        Success tone
+      </Text>
       <Icon source={CirclePlusMinor} tone="success" />
+      <Text as="p" variant="bodyMd" alignment="center">
+        Caution tone
+      </Text>
       <Icon source={CirclePlusMinor} tone="caution" />
+      <Text as="p" variant="bodyMd" alignment="center">
+        Warning tone
+      </Text>
       <Icon source={CirclePlusMinor} tone="warning" />
+      <Text as="p" variant="bodyMd" alignment="center">
+        Critical tone
+      </Text>
       <Icon source={CirclePlusMinor} tone="critical" />
+      <Text as="p" variant="bodyMd" alignment="center">
+        Emphasis tone
+      </Text>
+      <Icon source={CirclePlusMinor} tone="emphasis" />
+      <Text as="p" variant="bodyMd" alignment="center">
+        Magic tone
+      </Text>
       <Icon source={CirclePlusMinor} tone="magic" />
-    </div>
+      <Text as="p" variant="bodyMd" alignment="center">
+        Text Primary tone
+      </Text>
+      <Icon source={CirclePlusMinor} tone="textPrimary" />
+      <Text as="p" variant="bodyMd" alignment="center">
+        Text Caution tone
+      </Text>
+      <Icon source={CirclePlusMinor} tone="textCaution" />
+      <Text as="p" variant="bodyMd" alignment="center">
+        Text Warning tone
+      </Text>
+      <Icon source={CirclePlusMinor} tone="textWarning" />
+      <Text as="p" variant="bodyMd" alignment="center">
+        Text Critical tone
+      </Text>
+      <Icon source={CirclePlusMinor} tone="textCritical" />
+      <Text as="p" variant="bodyMd" alignment="center">
+        Text Info tone
+      </Text>
+      <Icon source={CirclePlusMinor} tone="textInfo" />
+      <Text as="p" variant="bodyMd" alignment="center">
+        Text Success tone
+      </Text>
+      <Icon source={CirclePlusMinor} tone="textSuccess" />
+      <Text as="p" variant="bodyMd" alignment="center">
+        Text Magic tone
+      </Text>
+      <Icon source={CirclePlusMinor} tone="textMagic" />
+    </BlockStack>
   );
 }
 

polaris-react/src/components/Icon/Icon.tsx

@@ -16,7 +16,15 @@ type Tone =
   | 'info'
   | 'success'
   | 'primary'
-  | 'magic';
+  | 'emphasis'
+  | 'magic'
+  | 'textCaution'
+  | 'textWarning'
+  | 'textCritical'
+  | 'textInfo'
+  | 'textSuccess'
+  | 'textPrimary'
+  | 'textMagic';
 
 export interface IconProps {
   /** The SVG contents to display in the icon (icons should fit in a 20 × 20 pixel viewBox) */