Skip to content

Commit 19e7c3d

Browse files
chazdeanlaurkim
authored andcommitted
[Typography foundations] Add responsive styling for heading2xl-4xl variants on <Text> (#7070)
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? This PR is a revision of #6919 without the un-needed commits <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page, Text} from '../src'; export function Playground() { return ( <Page title="Playground"> <Text as="h1" variant="heading4xl"> Heading4xl </Text> <Text as="h1" variant="heading3xl"> Heading3xl </Text> <Text as="h1" variant="heading2xl"> Heading2xl </Text> </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
1 parent 6020abb commit 19e7c3d

File tree

1 file changed

+21
-6
lines changed

1 file changed

+21
-6
lines changed

polaris-react/src/components/Text/Text.scss

Lines changed: 21 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -93,18 +93,33 @@
9393
}
9494

9595
.heading2xl {
96-
font-size: var(--p-font-size-500);
97-
line-height: var(--p-font-line-height-5);
96+
font-size: var(--p-font-size-300);
97+
line-height: var(--p-font-line-height-3);
98+
99+
@media #{$p-breakpoints-md-up} {
100+
font-size: var(--p-font-size-500);
101+
line-height: var(--p-font-line-height-5);
102+
}
98103
}
99104

100105
.heading3xl {
101-
font-size: var(--p-font-size-600);
102-
line-height: var(--p-font-line-height-6);
106+
font-size: var(--p-font-size-400);
107+
line-height: var(--p-font-line-height-4);
108+
109+
@media #{$p-breakpoints-md-up} {
110+
font-size: var(--p-font-size-600);
111+
line-height: var(--p-font-line-height-6);
112+
}
103113
}
104114

105115
.heading4xl {
106-
font-size: var(--p-font-size-700);
107-
line-height: var(--p-font-line-height-7);
116+
font-size: var(--p-font-size-600);
117+
line-height: var(--p-font-line-height-6);
118+
119+
@media #{$p-breakpoints-md-up} {
120+
font-size: var(--p-font-size-700);
121+
line-height: var(--p-font-line-height-7);
122+
}
108123
}
109124

110125
.bodySm {

0 commit comments

Comments
 (0)