Skip to content

Commit 47652f7

Browse files
authored
[Icons] Updates social media icons (#9856)
Updates social media icons by removing them from their containers so they are more identifiable. Also adds an icon for Twitch. <!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? We received feedback that the current icons were hard to distinguish when next to each other. <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
1 parent ee0496f commit 47652f7

21 files changed

+69
-18
lines changed

.changeset/chilled-numbers-shop.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@shopify/polaris-icons': minor
3+
---
4+
5+
Updates social media icons, removing them from their containers and adds a one for the Twitch platform.
Lines changed: 1 addition & 1 deletion
Loading
Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,12 @@
11
name: Facebook
22
set: Minor
3-
description:
4-
Facebook logo
3+
description: Facebook logo
54
keywords:
65
- facebook
76
- social media
87
authors:
98
- Joe Thomas
109
version: 1
1110
date_added: 2023-07-20
12-
date_modified: 2023-07-20
11+
date_modified: 2023-07-28
1312
exclusive_use:
Lines changed: 3 additions & 1 deletion
Loading
Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,12 @@
11
name: Instagram
22
set: Minor
3-
description:
4-
Instagram logo
3+
description: Instagram logo
54
keywords:
65
- instagram
76
- social media
87
authors:
98
- Joe Thomas
109
version: 1
1110
date_added: 2023-07-20
12-
date_modified: 2023-07-20
11+
date_modified: 2023-07-28
1312
exclusive_use:
Lines changed: 1 addition & 1 deletion
Loading

polaris-icons/icons/PintrestMinor.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,5 @@ authors:
88
- Joe Thomas
99
version: 1
1010
date_added: 2023-07-20
11-
date_modified: 2023-07-20
11+
date_modified: 2023-07-28
1212
exclusive_use:
Lines changed: 1 addition & 1 deletion
Loading

polaris-icons/icons/SnapchatMinor.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,5 @@ authors:
99
- Joe Thomas
1010
version: 1
1111
date_added: 2023-07-20
12-
date_modified: 2023-07-20
12+
date_modified: 2023-07-28
1313
exclusive_use:
Lines changed: 1 addition & 1 deletion
Loading

0 commit comments

Comments
 (0)