-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Commit 9b0fff7
[Button] Consolidate se23 logic and styles (#10040)
Resolves #9922.
Consolidates se23 beta logic and styles for `Button` and `_button.scss`.
Adds new styles where necessary in `Button.scss` to fix specificity
issues with styling.
Fixes Button tests.
[Storybook](https://5d559397bae39100201eedc1-uauurpoyku.chromatic.com/?path=/story/all-components-button--all)
[Prod
Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-button--all&globals=polarisSummerEditions2023:true)
> Things to tophat: UI and interactive states (i.e., focus, pressed,
hover) at different breakpoints
🖥 [Local development
instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development)
🗒 [General tophatting
guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md)
📄 [Changelog
guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)
- [x] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [x] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [ ] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide1 parent f41431f commit 9b0fff7Copy full SHA for 9b0fff7
File tree
Expand file treeCollapse file tree
4 files changed
+410
-775
lines changedOpen diff view settings
Filter options
- polaris-react/src
- components/Button
- tests
- styles/shared
Expand file treeCollapse file tree
4 files changed
+410
-775
lines changedOpen diff view settings
0 commit comments