Skip to content

Commit f82a661

Browse files
authored
Merge pull request #1243 from Shopify/fix-cancel-text
[ResourceList] - Adding bulk action cancel button translation
2 parents f5a8e04 + 839e900 commit f82a661

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

UNRELEASED.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ Use [the changelog guidelines](https://git.io/polaris-changelog-guidelines) to f
1818

1919
- Fixed disabled states while loading for `ResourceList` ([#1237](https://github.com/Shopify/polaris-react/pull/1237))
2020
- Fixed `Checkbox` from losing focus and not receiving some modified events([#1112](https://github.com/Shopify/polaris-react/pull/1112))
21+
- Added translation for the cancel button on the `ResourceList` `BulkActions` ([#1243](https://github.com/Shopify/polaris-react/pull/1243))
2122

2223
### Documentation
2324

src/components/ResourceList/components/BulkActions/BulkActions.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,7 @@ export class BulkActions extends React.PureComponent<CombinedProps, State> {
249249
testID="btn-cancel"
250250
disabled={disabled}
251251
>
252-
Cancel
252+
{intl.translate('Polaris.Common.cancel')}
253253
</button>
254254
);
255255

src/locales/en.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,8 @@
3030

3131
"Common": {
3232
"checkbox": "checkbox",
33-
"undo": "Undo"
33+
"undo": "Undo",
34+
"cancel": "Cancel"
3435
},
3536

3637
"ContextualSaveBar": {

0 commit comments

Comments
 (0)