Skip to content
This repository has been archived by the owner on Oct 1, 2024. It is now read-only.

tslib needs adding as a dependency to @shopify/function-enhancers #1240

Closed
jasonwilliams opened this issue Jan 21, 2020 · 6 comments
Closed

tslib needs adding as a dependency to @shopify/function-enhancers #1240

jasonwilliams opened this issue Jan 21, 2020 · 6 comments
Labels
stale Stale issue that hasn't received any attention in a while

Comments

@jasonwilliams
Copy link

Overview

@shopify/function-enhancers seems to be missing tslib as a dependency.

Here is an error i get when using "@shopify/react-i18n": "^2.1.3", with yarn pnp, without pnp i don't get the error.

[ error ] .cache/yarn/v6/npm-@shopify-function-enhancers-1.0.8-cc8907d5b8e5dea14d7e1a68f377685a051a4f0a-integrity/node_modules/@shopify/function-enhancers/dist/src/memoize.js
Module not found: Package "@shopify/function-enhancers@1.0.8" (via ".cache/yarn/v6/npm-@shopify-function-enhancers-1.0.8-cc8907d5b8e5dea14d7e1a68f377685a051a4f0a-integrity/node_modules/@shopify/function-enhancers/dist/src/memoize.js") is trying to require the package "tslib" (via "tslib") without it being listed in its dependencies (@shopify/function-enhancers)
[ error ] .cache/yarn/v6/npm-@shopify-function-enhancers-1.0.8-cc8907d5b8e5dea14d7e1a68f377685a051a4f0a-integrity/node_modules/@shopify/function-enhancers/dist/src/memoize.js
Module not found: Package "@shopify/function-enhancers@1.0.8" (via ".cache/yarn/v6/npm-@shopify-function-enhancers-1.0.8-cc8907d5b8e5dea14d7e1a68f377685a051a4f0a-integrity/node_modules/@shopify/function-enhancers/dist/src/memoize.js") is trying to require the package "tslib" (via "tslib") without it being listed in its dependencies (@shopify/function

...

This is on a next.js project which only emits this error when pnp is enabled on yarn.

It seems tslib has been added to other packages my guess is that this one was missed.
@jasonwilliams jasonwilliams changed the title Tslib needs adding as a dependency to @shopify/function-enhancers tslib needs adding as a dependency to @shopify/function-enhancers Jan 21, 2020
@stale
Copy link

stale bot commented Oct 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale issue that hasn't received any attention in a while label Oct 4, 2020
@stale stale bot closed this as completed Oct 12, 2020
@jasonwilliams
Copy link
Author

jasonwilliams commented Oct 12, 2020 •
edited
Loading

@b-ryu @alexandcote can you help?
This is still an issue

@alexandcote alexandcote reopened this Oct 16, 2020
@stale stale bot removed the stale Stale issue that hasn't received any attention in a while label Oct 16, 2020
@alexandcote alexandcote mentioned this issue Oct 16, 2020
Merged
2 tasks
@alexandcote
Copy link
Contributor

@jasonwilliams Sorry for the delay. I opened a PR #1657

@BPScott
Copy link
Member

BPScott commented Oct 16, 2020

Hi @jasonwilliams !

@jasonwilliams
Copy link
Author

Hey @BPScott! Let me know when you’re next in the UK

@stale
Copy link

stale bot commented Dec 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale issue that hasn't received any attention in a while label Dec 25, 2020
@ghost ghost closed this as completed Mar 16, 2021
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
stale Stale issue that hasn't received any attention in a while
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@BPScott @jasonwilliams @alexandcote