Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove currentBridge #2548

Merged
merged 3 commits into from
Aug 1, 2024

Conversation

WoLewicki
Copy link
Contributor

PR changing the occurence of currentBridge to properly retrieved self.bridge. If not applying this, on bridgeless mode the wrong instance of bridge is acquired, leading to adding JSI bindings to wrong runtime. It is possible that it only occurs when using expo in the project. See https://github.com/natedevxyz/rn-skia-test for reproduction.

@WoLewicki
Copy link
Contributor Author

After double-checking, this issue seems tightly connected to using expo. Nevertheless, as mentioned software-mansion/react-native-reanimated#5497 (comment), it is unsafe to use currentBridge and this approach should be the proper one.

@wcandillon
Copy link
Contributor

@WoLewicki thanks a lot :)

@wcandillon wcandillon self-requested a review July 31, 2024 13:06
@WoLewicki
Copy link
Contributor Author

Should I do something to push it forward?

@wcandillon wcandillon merged commit aadd424 into Shopify:main Aug 1, 2024
8 of 10 checks passed
@wcandillon
Copy link
Contributor

Will release it this morning :)

Copy link
Contributor

github-actions bot commented Aug 1, 2024

🎉 This issue has been resolved in version 1.3.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants