fix(🎨): fix race condition in SkiaDomView #2823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #2814 The race condition would occur when prop update in the view would trigger a redraw request, then the DOM would also emit a redraw request itself would get canceled due to the pending redraw. That first redraw request however, is not using the updated DOM version. We are rearchitecturing this part of the system at the moment, where such issues won't be possible anymore. However this should be good fix for now.
|
🎉 This PR is included in version 1.7.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2814
The race condition would occur when prop update in the view would trigger a redraw request, then the DOM would also emit a redraw request itself would get canceled due to the pending redraw. That first redraw request however, is not using the updated DOM version.
We are rearchitecturing this part of the system at the moment, where such issues won't be possible anymore. However this should be good fix for now.