We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currently, uniforms are passed to shaders as an array:
<Shader source={source} uniforms={[blue, r]} />
How about passing them as a map, the same way its done in gl-react? (see e.g. https://gl-react-cookbook.surge.sh/colordisc)
gl-react
<Shader source={source} uniforms={{blue, r}} />
Then order would not matter, but the object keys must match the uniform name in the shader.
The text was updated successfully, but these errors were encountered:
After checking canvaskit, this is probably a bad idea since we would then lose compatibility with canvaskit ...
Sorry, something went wrong.
not necessarily, we might be able to get from map to array using getUniformInfo() and this might be a good API change :)
4857f84
Successfully merging a pull request may close this issue.
Currently, uniforms are passed to shaders as an array:
How about passing them as a map, the same way its done in
gl-react
? (see e.g. https://gl-react-cookbook.surge.sh/colordisc)Then order would not matter, but the object keys must match the uniform name in the shader.
The text was updated successfully, but these errors were encountered: