Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorbet/StrictSigil is marked as safe for autocorrection, however it is not #267

Open
corsonknowles opened this issue Nov 9, 2024 · 3 comments

Comments

@corsonknowles
Copy link
Contributor

Changing this will clearly break Sorbet parsing without other additional, non-autocorrected changes

@KaanOzkan
Copy link
Contributor

Do you have an example where the autocorrect is incorrect?

@corsonknowles
Copy link
Contributor Author

Thanks!

I can circle back and make an example, but literally any file with method definitions but without signatures would be a good example.

That is to say this cannot be a safe autocorrect on untyped files, basically by definition

@KaanOzkan
Copy link
Contributor

Okay if I understand correctly you're saying StrictSigil autocorrect is unsafe because it can create typechecking errors.

That makes sense to me. Feel free to open a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants