fetch size overflow #1376
Merged
fetch size overflow #1376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
varun06
reviewed
Jun 25, 2019
|
Looks good to me, Do you want to sign CLA and add a test too. |
andrewhao888
force-pushed
the
m_consumer_fetch_size_overflow
branch
from
25f71e5 to
fa8b9f4
Compare
|
Yes, let me add a test case, as well as CLA |
|
sorry @varun06, it is too hard to provide a valid test case without mock broker update. A PartialTrailingRecord will lose trailing record after encoding. I just push a test case in fetch_response_test.go and sign CLA. Is that ok to merge? |
|
yeah, sounds good. |
bai
approved these changes
Jul 2, 2019
|
Thanks for your contribution, LGTM. |
varun06
approved these changes
Jul 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When getting a partial trailing message, consumer's fetch size will double.
However, it is possible to reach max int32, then a kafka broker receives a fetch request with negative fetch size.
Looks like this issue has been checked by Kafka itself with ticket: https://issues.apache.org/jira/browse/KAFKA-7656
Otherwise, we should provide a reasonable default Fetch.Max value