Add Consumer.HighWaterMarks() #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 20, 2016 14:02
|
I think I'm OK with this, but it is worth noting that the data returned by this call is not guaranteed to be consistent between partitions. It's probably worth noting that caveat in the documentation. |
eapache
reviewed
Oct 24, 2016
| @@ -63,6 +63,9 @@ type Consumer interface { | |||
| // or OffsetOldest | |||
| ConsumePartition(topic string, partition int32, offset int64) (PartitionConsumer, error) | |||
|
|
|||
| // HighWaterMarks returns the current high water marks for each topic and partitions | |||
There was a problem hiding this comment.
grammatically, you don't need to pluralize "partitions"
mathpl
force-pushed
the
feature/expose_high_water_mark
branch
2 times, most recently
from
bca64d9
to
c9eb295
Compare
mathpl
force-pushed
the
feature/expose_high_water_mark
branch
from
c9eb295
to
b0e729b
Compare
|
Modified the comments and now the CI fails, not sure what to do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a way for a consumer user to access the PartitionConsumers high water marks.