Producer: block in Close without Return.Errors
#787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If neither `Return.Errors` nor `Return.Successes` was set then `Close` wouldn't actually block at all. This is arguably correct given the send-it-into-the-void- and-pray configuration but it was still surprising. It turns out to be a very minimal change to block anyway (since the `Errors` channel is still present and closed at the appropriate moment) so just do that. Also add a test for this configuration, since it's not one I remember to think about on the regular.
|
This is awesome, I love how simple the solution was and it works beautifully. Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If neither
Return.ErrorsnorReturn.Successeswas set thenClosewouldn'tactually block at all. This is arguably correct given the send-it-into-the-void-
and-pray configuration but it was still surprising.
It turns out to be a very minimal change to block anyway (since the
Errorschannel is still present and closed at the appropriate moment) so just do that.
Also add a test for this configuration, since it's not one I remember to think
about on the regular.
@hchargois after poking around the code a bit I decided it was simpler to just fix this the way you suggested. Let me know if this works for you.
Closes #784.