Skip to content
This repository was archived by the owner on Apr 11, 2024. It is now read-only.

Add TLS to MySqlSessionStorage #461

Closed
4 tasks done
usama-m98 opened this issue Aug 21, 2022 · 3 comments
Closed
4 tasks done

Add TLS to MySqlSessionStorage #461

usama-m98 opened this issue Aug 21, 2022 · 3 comments
Labels

Comments

@usama-m98
Copy link

usama-m98 commented Aug 21, 2022

Overview

Currently there is no way to use TLS with MySQLSessionStorage.

Type

  • New feature
  • Changes to existing features

Motivation

What inspired this feature request? What problems were you facing?

I'm trying to connect my Azure MySQL database to MySQLSessionStorage and I need it to work with tls, but in the current iteration the dburl is coded in as a string and there is no way for me to add the option.

What I would like is to be able to add the tls option in like:

SESSION_STORAGE: new Shopify.Session.MySQLSessionStorage({ url: dbUrl, ssl: SSL_OPTIONS })

Area

  • Add any relevant Area: <area> labels to this issue

Checklist

  • I have described this feature request in a way that is actionable (if possible)
@liwson
Copy link

liwson commented Aug 23, 2022

Overview

Currently there is no way to use TLS with MySQLSessionStorage.

Type

  • New feature
  • Changes to existing features

Motivation

What inspired this feature request? What problems were you facing?

I'm trying to connect my Azure MySQL database to MySQLSessionStorage and I need it to work with tls, but in the current iteration the dburl is coded in as a string and there is no way for me to add the option.

What I would like is to be able to add the tls option in like:

SESSION_STORAGE: new Shopify.Session.MySQLSessionStorage({ url: dbUrl, ssl: SSL_OPTIONS })

Area

  • Add any relevant Area: <area> labels to this issue

Checklist

  • I have described this feature request in a way that is actionable (if possible)

This was referenced Aug 23, 2022
@github-actions
Copy link
Contributor

This issue is stale because it has been open for 90 days with no activity. It will be closed if no further action occurs in 14 days.

@github-actions github-actions bot added the Stale label Oct 23, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2022

We are closing this issue because it has been inactive for a few months.
This probably means that it is not reproducible or it has been fixed in a newer version.
If it’s an enhancement and hasn’t been taken on since it was submitted, then it seems other issues have taken priority.

If you still encounter this issue with the latest stable version, please reopen using the issue template. You can also contribute directly by submitting a pull request– see the CONTRIBUTING.md file for guidelines

Thank you!

@github-actions github-actions bot closed this as completed Nov 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants