tests

Author: djhoughton

lib/shopify_api/resources/product.rb

@@ -22,7 +22,7 @@ def total_inventory=(new_value)
     end
 
     def serializable_hash(options = {})
-      should_include_inventory_params ? super(options) : super(options).except("total_inventory")
+      should_include_inventory_params ? super(options) : super(options).except('total_inventory')
     end
 
     def collections

lib/shopify_api/resources/variant.rb

@@ -21,7 +21,7 @@ def old_inventory_quantity=(new_value)
     end
 
     def serializable_hash(options = {})
-      should_include_inventory_params ? super(options) : super(options).except("inventory_quantity", "old_inventory_quantity")
+      should_include_inventory_params ? super(options) : super(options).except('inventory_quantity', 'old_inventory_quantity')
     end
 
     private

test/product_test.rb

@@ -58,6 +58,23 @@ def test_price_range_when_has_different_price
     assert_equal('100.00 - 199.00', @product.price_range)
   end
 
+  def test_deprecated_variant_inventory_fields_are_included_in_2019_07
+    ShopifyAPI::Base.api_version = '2019-07'
+    variant = @product.variants.first
+    assert variant.as_json.include?('inventory_quantity')
+  end
+
+  def test_deprecated_variant_inventory_fields_are_removed_in_2020_01
+    ShopifyAPI::Base.api_version = '2020-01'
+    variant = @product.variants.first
+    refute variant.as_json.include?('inventory_quantity')
+  end
+
+  def test_deprecated_inventory_fields_are_removed_in_2020_01
+    ShopifyAPI::Base.api_version = '2020-01'
+    refute @product.as_json.include?('total_inventory')
+  end
+
   def test_setting_product_total_inventory_passes_in_api_before_2019_10
     ShopifyAPI::Base.api_version = '2019-07'
     fake("products/632910392", {:body => load_fixture('product')})

test/variant_test.rb

@@ -44,6 +44,20 @@ def test_delete_variant
     assert v.destroy
   end
 
+  def test_deprecated_inventory_fields_are_included_in_2019_07
+    ShopifyAPI::Base.api_version = '2019-07'
+    fake "products/632910392/variants/808950810", :method => :get, :body => load_fixture('variant')
+    variant = ShopifyAPI::Variant.find(808950810, :params => {:product_id => 632910392})
+    assert variant.as_json.include?('inventory_quantity')
+  end
+
+  def test_deprecated_inventory_fields_are_removed_in_2020_01
+    ShopifyAPI::Base.api_version = '2020-01'
+    fake "products/632910392/variants/808950810", :method => :get, :body => load_fixture('variant')
+    variant = ShopifyAPI::Variant.find(808950810, :params => {:product_id => 632910392})
+    refute variant.as_json.include?('inventory_quantity')
+  end
+
   def test_setting_variant_inventory_quantity_adjustment_passes_in_api_before_2019_10
     ShopifyAPI::Base.api_version = '2019-07'
     fake "products/632910392/variants/808950810", :method => :get, :body => load_fixture('variant')