Skip to content

Commit a456891

Browse files
Fixes issue 931, weight of variant should be float
Example in Shopify/shopify had an integer (100) for weigth thus wrapper generation inferred Integer. Changed the example to 100.0 to correct it in the generated wrappers.
1 parent afc2565 commit a456891

File tree

9 files changed

+63
-60
lines changed

9 files changed

+63
-60
lines changed

CHANGELOG.md

+3
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22

33
## Unreleased
44

5+
### Fixed
6+
- [#935](https://github.com/Shopify/shopify_api/pull/935) Fix issue [#931](https://github.com/Shopify/shopify_api/pull/931), weight of variant should be float
7+
58
## Version 10.0.2
69

710
- [#929](https://github.com/Shopify/shopify_api/pull/929) Aligning sorbet dependencies

lib/shopify_api/rest/resources/2021_07/variant.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ def initialize(session: ShopifyAPI::Context.active_session)
3636
@taxable = T.let(nil, T.nilable(T::Boolean))
3737
@title = T.let(nil, T.nilable(String))
3838
@updated_at = T.let(nil, T.nilable(String))
39-
@weight = T.let(nil, T.nilable(Integer))
39+
@weight = T.let(nil, T.nilable(Float))
4040
@weight_unit = T.let(nil, T.nilable(String))
4141
end
4242

@@ -103,7 +103,7 @@ def initialize(session: ShopifyAPI::Context.active_session)
103103
attr_reader :title
104104
sig { returns(T.nilable(String)) }
105105
attr_reader :updated_at
106-
sig { returns(T.nilable(Integer)) }
106+
sig { returns(T.nilable(Float)) }
107107
attr_reader :weight
108108
sig { returns(T.nilable(String)) }
109109
attr_reader :weight_unit

lib/shopify_api/rest/resources/2021_10/variant.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ def initialize(session: ShopifyAPI::Context.active_session)
3636
@taxable = T.let(nil, T.nilable(T::Boolean))
3737
@title = T.let(nil, T.nilable(String))
3838
@updated_at = T.let(nil, T.nilable(String))
39-
@weight = T.let(nil, T.nilable(Integer))
39+
@weight = T.let(nil, T.nilable(Float))
4040
@weight_unit = T.let(nil, T.nilable(String))
4141
end
4242

@@ -103,7 +103,7 @@ def initialize(session: ShopifyAPI::Context.active_session)
103103
attr_reader :title
104104
sig { returns(T.nilable(String)) }
105105
attr_reader :updated_at
106-
sig { returns(T.nilable(Integer)) }
106+
sig { returns(T.nilable(Float)) }
107107
attr_reader :weight
108108
sig { returns(T.nilable(String)) }
109109
attr_reader :weight_unit

lib/shopify_api/rest/resources/2022_01/variant.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ def initialize(session: ShopifyAPI::Context.active_session)
3636
@taxable = T.let(nil, T.nilable(T::Boolean))
3737
@title = T.let(nil, T.nilable(String))
3838
@updated_at = T.let(nil, T.nilable(String))
39-
@weight = T.let(nil, T.nilable(Integer))
39+
@weight = T.let(nil, T.nilable(Float))
4040
@weight_unit = T.let(nil, T.nilable(String))
4141
end
4242

@@ -103,7 +103,7 @@ def initialize(session: ShopifyAPI::Context.active_session)
103103
attr_reader :title
104104
sig { returns(T.nilable(String)) }
105105
attr_reader :updated_at
106-
sig { returns(T.nilable(Integer)) }
106+
sig { returns(T.nilable(Float)) }
107107
attr_reader :weight
108108
sig { returns(T.nilable(String)) }
109109
attr_reader :weight_unit

lib/shopify_api/rest/resources/2022_04/variant.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ def initialize(session: ShopifyAPI::Context.active_session)
3636
@taxable = T.let(nil, T.nilable(T::Boolean))
3737
@title = T.let(nil, T.nilable(String))
3838
@updated_at = T.let(nil, T.nilable(String))
39-
@weight = T.let(nil, T.nilable(Integer))
39+
@weight = T.let(nil, T.nilable(Float))
4040
@weight_unit = T.let(nil, T.nilable(String))
4141
end
4242

@@ -103,7 +103,7 @@ def initialize(session: ShopifyAPI::Context.active_session)
103103
attr_reader :title
104104
sig { returns(T.nilable(String)) }
105105
attr_reader :updated_at
106-
sig { returns(T.nilable(Integer)) }
106+
sig { returns(T.nilable(Float)) }
107107
attr_reader :weight
108108
sig { returns(T.nilable(String)) }
109109
attr_reader :weight_unit

test/rest/2021_07/variant_test.rb

+13-13
Large diffs are not rendered by default.

test/rest/2021_10/variant_test.rb

+13-13
Large diffs are not rendered by default.

test/rest/2022_01/variant_test.rb

+13-13
Large diffs are not rendered by default.

test/rest/2022_04/variant_test.rb

+13-13
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)