Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to run Sorbet type check on GitHub actions #981

Closed
tatsuya opened this issue Jun 24, 2022 · 0 comments · Fixed by #980
Closed

Unable to run Sorbet type check on GitHub actions #981

tatsuya opened this issue Jun 24, 2022 · 0 comments · Fixed by #980
Assignees
Labels

Comments

@tatsuya
Copy link
Contributor

tatsuya commented Jun 24, 2022

Issue summary

https://github.com/Shopify/shopify_api/runs/7036271248?check_suite_focus=true

Screen Shot 2022-06-24 at 4 04 01 PM

sorbet/rbi/todo.rbi is outdated causing the GitHub build workflow failure like below:

Run bundle exec srb tc
sorbet/rbi/todo.rbi:7: `RDoc::Task` was previously defined as a `class` https://srb.help/[4](https://github.com/Shopify/shopify_api/runs/7036271248?check_suite_focus=true#step:7:5)012
     7 |module RDoc::Task; end
        ^^^^^^^^^^^^^^^^^
    https://github.com/sorbet/sorbet/tree/0b0b87fe[5](https://github.com/Shopify/shopify_api/runs/7036271248?check_suite_focus=true#step:7:6)34cd33bc[6](https://github.com/Shopify/shopify_api/runs/7036271248?check_suite_focus=true#step:7:7)0e9b5c65[7](https://github.com/Shopify/shopify_api/runs/7036271248?check_suite_focus=true#step:7:8)4565973593d1e/rbi/stdlib/rdoc.rbi#L9339: Previous definit
    9339 |class RDoc::Task
          ^^^^^^^^^^^^^^^^
Errors: 1
Error: Process completed with exit code 1.

Expected behavior

GitHub flow passes successfully.

Actual behavior

GitHub flow fails.

Steps to reproduce the problem

Open a pull request (example)

Specifications

  • shopify_api version: N/A
  • Shopify API version used (example: 2020-07): N/A
@tatsuya tatsuya added the bug label Jun 24, 2022
@tatsuya tatsuya mentioned this issue Jun 24, 2022
5 tasks
@tatsuya tatsuya self-assigned this Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant