Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add customLink prop to the app provider to set custom Remix Link #486

Open
blanklob opened this issue Jan 7, 2024 · 2 comments
Open

Add customLink prop to the app provider to set custom Remix Link #486

blanklob opened this issue Jan 7, 2024 · 2 comments
Labels
good first issue Good for newcomers

Comments

@blanklob
Copy link
Contributor

blanklob commented Jan 7, 2024

Issue summary

https://www.loom.com/share/dd7acddb992548a18760bc88c6fef3fd?sid=1e2316f7-9c28-4c99-a71e-c43b0463aaaa

  • @shopify/shopify-app-remix version:
  • Node version:
  • Operating system:
// Paste any relevant logs here

Expected behavior

Actual behavior

Steps to reproduce the problem

@lizkenyon
Copy link
Contributor

Hi there 👋

Thanks for reaching out! The team review and look into this!

The loom is super helpful! If possible could you add in writing, the use case you would use this for. That would also be super helpful! (Just so we can quickly skim this without having to watch the video each time.) 😄

@blanklob
Copy link
Contributor Author

blanklob commented Jan 8, 2024

in nutshell add ability to do add custom link component like we do with Polaris provider, coz we wanna access more state.

<AppProvider apiKey={apiKey} customLink={<NavLink />}...</AppProvider> 

@lizkenyon lizkenyon added the good first issue Good for newcomers label Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants