Skip to content
This repository has been archived by the owner on Jul 27, 2024. It is now read-only.

Add support for hover language client requests #178

Closed
charlespwd opened this issue Feb 25, 2021 · 2 comments
Closed

Add support for hover language client requests #178

charlespwd opened this issue Feb 25, 2021 · 2 comments
Labels
blocked For when you can't work on something e:3 Effort: 3 language server Language Server related issues p:medium Priority (or Impact): Medium

Comments

@charlespwd
Copy link
Contributor

charlespwd commented Feb 25, 2021 •
edited
Loading

We should show the documentation of tags, objects, filters when hovering on known objects.

https://microsoft.github.io/language-server-protocol/specifications/specification-current/#textDocument_hover

Related to Shopify/theme-tools#449
@charlespwd charlespwd added the language server Language Server related issues label Feb 25, 2021
@charlespwd charlespwd added p:medium Priority (or Impact): Medium e:3 Effort: 3 labels Mar 25, 2021
@charlespwd charlespwd added the blocked For when you can't work on something label Nov 26, 2021
@charlespwd
Copy link
Contributor Author

Depends on Shopify/theme-tools#449

@lukeh-shopify
Copy link
Contributor

Closed as needs more info - we already have hover?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
blocked For when you can't work on something e:3 Effort: 3 language server Language Server related issues p:medium Priority (or Impact): Medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@charlespwd @lukeh-shopify