Skip to content
This repository has been archived by the owner on Jul 27, 2024. It is now read-only.

Clarify Documentation #746

Closed
wants to merge 3 commits into from
Closed

Conversation

dbolesta
Copy link

Cleans up a bit of the img_width_and_height doc to make things clearer.

  • Removes a reference definition that was not being used anywhere in the document
  • Adds a reference link to clarify the "padding-top hack", which is not common knowledge, and provides further context to what a "padding-top hack" is and how it works.
  • Fixes an error where the word "container" was places inside the small css snippet in error.overflow: hidden container makes it seems like container is a CSS value, when really what is means is "a container with overflow: hidden CSS rule applied to it".

@lukeh-shopify
Copy link
Contributor

👋🏻 Hi @dbolesta! Thanks for your contribution. Unfortunately the Ruby version of theme check is no longer receiving dev support and is in the process of being deprecated.

Our recommendation is to use the latest version of theme check via the latest version of the Shopify CLI, or via the Shopify Liquid Visual Studio Code extension.

If there are docs that need clarifying over there, please raise an issue or make a change over in the CLI or theme tools repositories. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants