New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate translations in config/settings_schema.json #456

Open

macournoyer opened this issue Dec 10, 2020 · 0 comments

Labels

area:theme-check enhancement

Contributor

macournoyer commented Dec 10, 2020

This is only about translations validate. See Shopify/theme-check#70 for validating the format of the file.

Doesn't seem to be documented anywhere, but settings_schema.json accepts translations:

[
  {
    "name": {
      "cs": "Barvy",
      "da": "Farver",
      "de": "Farben",
      "en": "Colors"
    },
    "settings": [
      {
        "id": "colors_text",
        "type": "color",
        "default": "#232734",
        "label": {
          "cs": "Text",
          "da": "Tekst",
          "de": "Text",
          "en": "Text"
        }
...

We should do the same checks we do inside {% schema %}. See Shopify/theme-check#62.

The text was updated successfully, but these errors were encountered:

lukeh-shopify transferred this issue from Shopify/theme-check

lukeh-shopify added enhancement area:theme-check labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment