Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert project to TypeScript #132

Open
5 of 8 tasks
ShrimpCryptid opened this issue Apr 13, 2024 · 2 comments · Fixed by #131
Open
5 of 8 tasks

Convert project to TypeScript #132

ShrimpCryptid opened this issue Apr 13, 2024 · 2 comments · Fixed by #131
Assignees
Labels
frontend Pull requests that update frontend Javascript/Typescript code needs detail tech debt Refactors, modernization, codebase redesign
Milestone

Comments

@ShrimpCryptid
Copy link
Owner

ShrimpCryptid commented Apr 13, 2024

In the process of converting core elements of the frontend from JavaScript to TypeScript to make future development easier.

TODOs:

  • Add a warning note on the front page about the new changes, requesting that players be vigilant for bugs
  • [ ] Delete the Twitter buttons and elements; they don't work on certain browsers, like Brave moved to Update Twitter share buttons  #136

Known bugs:

  • Player roles are not shown on victory screen for liberal players
  • In developer mode, hot reload will cause the websocket connection to stay open in the background, blocking logins and causing other strange behavior.
  • PlayerDisplay does not show roles during final victory screen.
  • During victory sequence, the last action (execution/voting) should be shown for more suspense! (not a bug introduced here but a general sentiment)
  • PlayerDisplay shows all roles for fascist players. (maybe ok?)
  • Initial Role display shows incorrect card for Liberals
@ShrimpCryptid ShrimpCryptid linked a pull request Apr 13, 2024 that will close this issue
@ShrimpCryptid
Copy link
Owner Author

ShrimpCryptid commented Apr 14, 2024

image

Notes:

  • Disconnects may be caused by a race condition (multiple websockets trying to open at once; see how the number of failed connections is the same for like. 5 websocket connection attempts). The websocket onClose will still execute even if the current websocket is active.

@ShrimpCryptid
Copy link
Owner Author

Note: This needs a defined scope. Maybe refactoring App.tsx is a good final goal?

@ShrimpCryptid ShrimpCryptid moved this from New to In progress in Secret Hitler Online Apr 17, 2024
@ShrimpCryptid ShrimpCryptid self-assigned this Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Pull requests that update frontend Javascript/Typescript code needs detail tech debt Refactors, modernization, codebase redesign
Projects
Status: In progress
Development

Successfully merging a pull request may close this issue.

1 participant