Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build for web #9

Open
Shuunen opened this issue Sep 26, 2018 · 7 comments
Open

build for web #9

Shuunen opened this issue Sep 26, 2018 · 7 comments
Labels
enhancement New feature or request

Comments

@Shuunen
Copy link
Owner

Shuunen commented Sep 26, 2018

No description provided.

@Shuunen Shuunen added the enhancement New feature or request label Sep 26, 2018
@Shuunen Shuunen mentioned this issue Sep 26, 2018
@ctf0
Copy link

ctf0 commented Sep 26, 2018

btw there are also lots of console.log and comments in the logic, if you dont need them it would a good thing to clean them up

@Shuunen
Copy link
Owner Author

Shuunen commented Sep 26, 2018

can we build a clean version of this component ? the build will clean comments, logs & minify everything

@ctf0
Copy link

ctf0 commented Sep 26, 2018

the console.logs and comments usually gets removed on build when using something like uglify, however if all the comments are essential then we can leave em.

also i think it would be a good idea if we built a browser module file so everyone can use it without the need for a build system.

@Shuunen
Copy link
Owner Author

Shuunen commented Sep 26, 2018

with something like this ? https://github.com/egoist/bili

@ctf0
Copy link

ctf0 commented Sep 26, 2018

if u know how to use it then go for it 🏅

@Shuunen
Copy link
Owner Author

Shuunen commented Sep 26, 2018

haha I did not 😋 i just saw this lib starred by one of the person I follow

but I'll try

you know how to do this kind of thing ?

@ctf0
Copy link

ctf0 commented Sep 27, 2018

honestly no 😢

@Shuunen Shuunen changed the title Use of reset ? build for web May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants