Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum altitude is not necessarily the first point #70

Open
miqwit opened this issue Mar 8, 2024 · 3 comments
Open

Minimum altitude is not necessarily the first point #70

miqwit opened this issue Mar 8, 2024 · 3 comments

Comments

@miqwit
Copy link
Contributor

miqwit commented Mar 8, 2024

$this->stats->minAltitude = $firstPoint->elevation;

In some sports or activities, including hiking, you could start from a higher point than the one you finish. Using the ElevationGainLossCalculator could return the lowest elevation in the points without considering the first one necessarily.

@Sibyx
Copy link
Owner

Sibyx commented Mar 8, 2024

Yeah, makes sense. Would you like to have it resolved in 1.x or 2.x?

@miqwit
Copy link
Contributor Author

miqwit commented Mar 8, 2024

I have no idea, really.... both? :)

@Sibyx
Copy link
Owner

Sibyx commented Mar 10, 2024

@miqwit yeah, that would be a best case :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants