Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Const Tracing #115

Open
goto-bus-stop opened this issue Apr 17, 2020 · 0 comments
Open

Const Tracing #115

goto-bus-stop opened this issue Apr 17, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@goto-bus-stop
Copy link
Member

Zetnus showed a script like this:

if UP_EXTENSION #define RND_AVAILABLE
elseif DE_AVAILABLE #define RND_AVAILABLE
endif

if ALLOW_FULL_RANDOM_PLACEMENT
    if RND_AVAILABLE    /* a check for direct-placement support */
        start_random
            percent_chance 10    #define USE_FULL_RANDOM_PLACEMENT     
        end_random
    endif
endif

if USE_FULL_RANDOM_PLACEMENT
    direct_placement
endif

rms-check flags this as a potential compatibility issue. However, USE_FULL_RANDOM_PLACEMENT will only ever be defined if UP_EXTENSION or DE_AVAILABLE is defined, so this is actually fine. We could do dependency tracing of const definitions to account for this.

@goto-bus-stop goto-bus-stop added the enhancement New feature or request label Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant