Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add prettier and eslint checks in pre commit hooks #235

Closed
nidhi-tandon opened this issue Jul 18, 2021 · 4 comments · Fixed by #904
Closed

feat: add prettier and eslint checks in pre commit hooks #235

nidhi-tandon opened this issue Jul 18, 2021 · 4 comments · Fixed by #904
Assignees
Labels

Comments

@nidhi-tandon
Copy link
Contributor

Is your feature request related to a problem?

Add prettier and eslint checks on staged files while commiting

Describe the solution you'd like

We can use lint staged to solve this
Adding prettier and eslint will resolve all the inconsistencies in the code and will help in code maintainability.

Describe alternatives you've considered

Additional context

Add any other context or screenshots about the feature request here.

Thank you for your feature request – we love each and every one!

@saideepesh000
Copy link
Contributor

Hey @nidhi-tandon , I'm assigning this to myself

@saideepesh000 saideepesh000 self-assigned this Jul 18, 2021
@palashgdev
Copy link
Contributor

Hi @saideepesh000 I think eslint-prettier is already resolved in this #214

can you please look into husky.

Do let me know

@palashgdev
Copy link
Contributor

please also look into #234

@palashgdev
Copy link
Contributor

Hi @saideepesh000
I am taking this issue .. due to inactivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants