Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Log Parsing Pipelines] filters referencing names whose dots have been replaced with underscores don't work #4061

Closed
raj-k-singh opened this issue Nov 24, 2023 · 2 comments

Comments

@raj-k-singh
Copy link
Collaborator

raj-k-singh commented Nov 24, 2023

We replace dots with underscores for attributes before storing them in the DB right now.

cc @nityanandagohain

@raj-k-singh
Copy link
Collaborator Author

This also affects pipeline processing of extracted attributes if the user names an extracted attributes with dots.

  • The preview shows dot based attrib names in simulation output but actual logs have underscore.
  • Users can end up adding more processors targeting underscore based attribute names (seen in final logs) even though in the log being processed in the collector the attribute would have a name with a dot.

@raj-k-singh raj-k-singh self-assigned this Dec 12, 2023
@raj-k-singh
Copy link
Collaborator Author

We do not replace dots with underscores in logs anymore.
Closing this issue and using https://github.com/SigNoz/engineering-pod/issues/1166 to track migration of existing pipelines and removal of mitigation logic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants