Display Version emety

[OfficialEsco]

Hello again, back with some nitpicking 🙄
Would you mind adding the version number to the Display Version field in the registry so it shows up in Add or Remove Programs?

This is another nitpick issue from WinGet as it looks at the Registry keys for the currently installed version, if you add the Display Version it will make winget list and winget upgrade work as expected.

Issue on our side: microsoft/winget-pkgs#24325

[BeckyDTP]

Root: HKLM; Subkey: "SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\{#AppName}_is1"; ValueType: string; ValueName: "DisplayVersion"; ValueData: "${SIGIL_FULL_VERSION}"

It should be enought.

[dougmassay]

My understanding of Inno Setup (which is not exhaustive by any means) is that the version from AppVerName should be used for this if AppVersion is not set. This is clearly not happening though. I'll look into it. There should be no need to do it manually in the registry section of the iss file, however. I'll look into it and get it sorted for the next release.

This is not a dig (well not much of one any way!), but coming from a Linux background, I find it a little odd that most Windows software repositories seem to rely on upstream, prebuilt installers to do their heavy lifting. Patching, building from source, and debundling system dependencies (like Qt5 and Python) is the job of a maintainer in the Linux packaging world.

Just an observation, though. Happy to oblige where I can do so easily (plus this fix will benefit all users, not just those who use winget).

[dougmassay]

This seems to do the trick: 530bf4e

Feel free to use this continuous-integration build for testing (unless you build your own, of course). They get uploaded to my personal google-drive. It will have both this fix and the previous msgbox suppression ability.

https://drive.google.com/file/d/1-SjRmhPiguriaX97bXx5SO9VXCarnJQA/view?usp=sharing

[eli-schwartz]

Well, Microsoft does apparently have an interest in running a real appstore, for the first time ever. Maybe they'll surprise us all, and allow open source applications to upload recipes instead of installers, and have those recipes use shared frameworks for things like Qt.

Miracles do happen, occasionally.

[dougmassay]

Oh, I'm not knocking it. It's just that all of the various Windows software repository projects (official or otherwise) seem to completely ignore the shared dependency maintenance angle thus far. Maybe they'll get there eventually.

[eli-schwartz]

I guess cygwin and msys2 use shared dependencies. But yeah, for any serious distribution case it's a big field of missed opportunity.

[dougmassay]

Hey, are you on a package update hiatus over at Arch? I'm not in any way stressed about it (your schedule is your schedule), just curious, really. I just don't think I recall ever seeing calibre or sigil flagged as of of date for so long.

[dougmassay]

Closing this issue as fixed.

[dougmassay]

I sort of assumed the update process for Sigil on winget was automated. If this is not the case, is there a preferred way of pinging whoever is maintaining the Sigil Manifest for winget whenever we release a new version? Not sure if that's @OfficialEsco or someone else.

[OfficialEsco]

That does indeed appear to be me, however it should also be updated by winget-pkgs-automation according to this sigil-ebook.sigil.json

• [Bug]: Sigil-Ebook.Sigil not getting updated vedantmgoyal9/vedantmgoyal9#499

[dougmassay]

I don't know all the particulars, but it it looks to me that the issue might be the version reference in that json. The lookbehind expression seems to be expecting a 'v' in the version/tag which is trimmed off later.

"VersionRegex": "(?<=v)[0-9.]+"

Sigil tags don't start with a 'v'.

I could be all wet about how the automation checks version numbers, though. Thanks for looking into it! I'm sure it will get sorted.