fix: change to new unsplash api #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the old and now deprecated Unsplash API endpoint to the new unsplash API.
Because the new API requires authentication, I created a small express add hosted at https://templater-unsplash.fly.dev/ which acts as a proxy for the unsplash api. This way the Auth Key won't be exposed on the client.
The server-side code can be reviewed here: https://github.com/shabegom/templater-unsplash-proxy
The one potential issue is that the API has a rate limit of 50 images per hour unless you apply for production-level access. Some of the API guidelines make production-level access undesirable. To try and loosely adhere to the guidelines, the text of a random_picture will now include attribution to the photographer.