Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: tp.file.exists in Obsidian v1.0.0 always returns false for files; #879

Merged
merged 2 commits into from
Oct 29, 2022
Merged

Bug: tp.file.exists in Obsidian v1.0.0 always returns false for files; #879

merged 2 commits into from
Oct 29, 2022

Conversation

jlharri
Copy link
Contributor

@jlharri jlharri commented Oct 23, 2022

Addresses #878 in 2 ways:

  1. Fixes documentation to reflect that tp.file.exists requires a full path.
  2. Adds a call to normalizePath() inside exists() function so that templates can work across Windows and *nix OS'.

@jlharri
Copy link
Contributor Author

jlharri commented Oct 23, 2022

Let me know if I've screwed something up with the PR. I had to make a second commit for InternalModuleFile.ts.

@shabegom
Copy link
Collaborator

Thanks for the PR. Will review when I have some time. At a glance it looks good!

@shabegom shabegom merged commit fc08873 into SilentVoid13:master Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jlharri @shabegom