Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow additional file extensions for markdown files #455

Closed
matkoch opened this issue Feb 1, 2022 · 9 comments
Closed

Allow additional file extensions for markdown files #455

matkoch opened this issue Feb 1, 2022 · 9 comments
Labels
Milestone

Comments

@matkoch
Copy link

matkoch commented Feb 1, 2022

Is the feature request related to a problem

.mdx files are mostly like .md files with the exception that they also allow JSX to be used. Currently MarkdownSnippets only scans for .md files.

Describe the solution

Either another option could be added to specify user-relevant markdown files, or .mdx could be added hardcoded to the traversed types of files.

Describe alternatives considered

None

Additional context

None.

@SimonCropp
Copy link
Owner

@matkoch
Copy link
Author

matkoch commented Feb 1, 2022

you mean to reference the snippet in the md file and then include in mdx? i can try later, but even if, i'm sure the organizational effort would be a real pain

@matkoch
Copy link
Author

matkoch commented Feb 1, 2022

yes it seems to work, but as I said, it's rather cumbersome having to outsource dozens of snippets into their own files

@matkoch
Copy link
Author

matkoch commented Feb 1, 2022

Ah nevermind, includes don't work. I was looking at the wrong file.

@SimonCropp
Copy link
Owner

rather cumbersome having to outsource dozens of snippets into their own files

it not about having snippets in their own files. it is about having a re-usable chunks of markdown that can be consumed by other markdown files

@matkoch
Copy link
Author

matkoch commented Feb 1, 2022

i'm not sure what's the difference in the case I'm talking about. every snippet would have to go into its own .include.md file just to be processed by the mdsnippets, and to be included separately into an .mdx file ... but in any case – includes don't seem to work

@SimonCropp
Copy link
Owner

can u try 24.3.0-beta.1

@matkoch
Copy link
Author

matkoch commented Feb 2, 2022

LGTM! :shipit: Thanks!

@SimonCropp SimonCropp added this to the 24.3.0 milestone Feb 2, 2022
@SimonCropp
Copy link
Owner

shipping now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants