Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hcat, vcat, hvcat, and cat #52

Open
schmrlng opened this issue Oct 7, 2015 · 2 comments
Open

hcat, vcat, hvcat, and cat #52

schmrlng opened this issue Oct 7, 2015 · 2 comments

Comments

@schmrlng
Copy link

schmrlng commented Oct 7, 2015

When using ImmutableArrays.jl, the fact that everything is a subtype of Base.AbstractArray makes the various concatenation operations work automatically (promoting everything to a dense array, which seems reasonable when you're already growing array sizes). On the roadmap it looks like inheriting from AbstractArray is an eventual goal; do you have an idea of what work needs to get done to make that happen? If it seems pretty far off, in the mean time would it make sense to PR in some hacks (also for slicing, etc.)?

@SimonDanisch
Copy link
Owner

Yes, it is relatively far off, mainly due to time constraints and priorities :(
The issues to look out for are: JuliaLang/LinearAlgebra.jl#255, JuliaLang/julia#11610 and JuliaLang/julia#11902
The first two are somewhat interchangable, but at least one of them needs to be resolved. The last is just helpful ;)
If you have some time and want to play around with slices and stuff like that, feel free to open PR's!
If things are not documented well enough, feel free to ask any questions here or on gitter!

Best,
Simon

@c42f
Copy link
Collaborator

c42f commented Jul 11, 2016

Just a note that I started looking at this (see the first commit on the concatenation branch which contains a partial implementation), but may not get back to it for a little while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants