Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have a landing page before OAuth #17

Closed
tupui opened this issue Oct 23, 2023 · 2 comments
Closed

Have a landing page before OAuth #17

tupui opened this issue Oct 23, 2023 · 2 comments
Labels
dashboard enhancement New feature or request

Comments

@tupui
Copy link
Member

tupui commented Oct 23, 2023

No description provided.

@tupui tupui added enhancement New feature or request dashboard labels Oct 23, 2023
@tupui
Copy link
Member Author

tupui commented Oct 24, 2023

See https://discourse.holoviz.org/t/landing-page-with-oauth/6256/2

or another suggestion is to change the user:

philippjfr — Discord
I think the best place is here
panel/panel/auth.py at main · holoviz/panel
Basically you'd check if handler.request.uri is one of the valid paths and then return 'guest' even when no user cookie is defined.
Oh and for the basic auth you'd do the same on that handler's get_user function.

@tupui
Copy link
Member Author

tupui commented Oct 26, 2023

Have a solution with 6eae034

Long term plan is to have this feature in Panel directly, PR in progress. xref holoviz/panel#5743

@tupui tupui closed this as completed Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dashboard enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tupui