Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The game crashes with FabricSkyboxes #24

Closed
Lolothepro opened this issue Aug 10, 2023 · 1 comment
Closed

The game crashes with FabricSkyboxes #24

Lolothepro opened this issue Aug 10, 2023 · 1 comment
Labels
compat A mod is found to be incompatible

Comments

@Lolothepro
Copy link

Mod Name

FabricSkyboxes

Mod Homepage

https://modrinth.com/mod/fabricskyboxes

Describe the bug

Game crashes on startup.

Steps to reproduce

No response

Logs

https://mclo.gs/o9ETXqY

Additional context

No response
@Lolothepro Lolothepro added the compat A mod is found to be incompatible label Aug 10, 2023
@Su5eD
Copy link
Member

Su5eD commented Aug 11, 2023

This was caused by the fabric sky boxes mod using an invalid url for their website contact. According to fabric's documentation, it should be a valid URL starting with http(s)://.

  • contact Defines the contact information for the project. It is an object of the following fields:
    • homepage Project or user homepage. Must be a valid HTTP/HTTPS address.

I added a check to make sure the URL is valid before it is passed into FML, eliminating the crash. However, the mod should also update itself to be compliant with the spec.

Good news is the mod itself works fine:

@Su5eD Su5eD closed this as completed Aug 11, 2023
@Lolothepro Lolothepro mentioned this issue Aug 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compat A mod is found to be incompatible
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Su5eD @Lolothepro