Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pushItems and pullItems returns 2x the real transfer count #38

Closed
runi95 opened this issue Jun 21, 2024 · 7 comments
Closed

pushItems and pullItems returns 2x the real transfer count #38

runi95 opened this issue Jun 21, 2024 · 7 comments
Assignees
Labels
awaiting release Issue resolved but there is no release yet
Milestone

Comments

@runi95
Copy link

runi95 commented Jun 21, 2024

Reproduction steps:

  1. Place down Chest
  2. Put 26 Dirt into slot 1 of Chest
  3. Place down Advanced Turtle facing the Chest
  4. Right click the Advanced Turtle to open the turtle interface
  5. > lua
  6. lua> peripheral.call("front", "pushItems", "front", 1, nil, 2)

The peripheral call returns 52 (transferred items), but the chest only contains 26 Dirt which has now been moved to slot 2. This does not happen with just CC: Tweaked installed alone, but as soon as UnlimitedPeripheralWorks is added the bug occurs.

NOTE: This bug only seems to appear when pushing or pulling items within the same inventory (ex: When wanting to move an item from one slot to another within the same chest), but as far as I can tell it does not seem to occur when transferring items between 2 separate inventories.

@SirEdvin
Copy link
Owner

SirEdvin commented Jun 21, 2024

Linking CC:T issue

@SirEdvin
Copy link
Owner

@runi95 which version of UPW and Peripheralium you using? I can't reproduce this behaviour

@SirEdvin SirEdvin self-assigned this Jun 26, 2024
@SirEdvin SirEdvin added the question Further information is requested label Jun 26, 2024
@runi95
Copy link
Author

runi95 commented Jun 27, 2024

@SirEdvin Not sure if it matters, but I've been running this on Fabric instead of Forge and I'm encountering this issue when running on:

  • Minecraft 1.20.1
  • Fabric loader 0.15.11

With the following mods:

  • CC:Tweaked 1.111.0
  • UnlimitedPeripheralWorks 1.4.3
  • Peripheralium 0.6.15
  • *Fabric API 0.92.2
  • *Fabric Language Kotlin 1.11.0
  • *Forge Config API 8.0.0

*Are required to run these mods on Fabric

@SirEdvin
Copy link
Owner

I find it very ironic that Fabric API upgrade cause this issue

@SirEdvin SirEdvin added awaiting release Issue resolved but there is no release yet and removed question Further information is requested labels Jun 27, 2024
@SirEdvin
Copy link
Owner

But of course, the root of this issue was my code :)

@runi95
Copy link
Author

runi95 commented Jun 27, 2024

Hehe, I definitely feel you! I found it pretty odd too and thought it was a CC:Tweaked issue to begin with. Until I started testing with CC:Tweaked alone.
Still found an oddity in how CC:Tweaked performed, but it wasn't quite the same issue.

@SirEdvin SirEdvin added this to the 1.4.4 milestone Aug 12, 2024
@SirEdvin
Copy link
Owner

Fixed in 1.4.4 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting release Issue resolved but there is no release yet
Projects
None yet
Development

No branches or pull requests

2 participants