Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DGrid does not get value upon notification of change from custom dijit #1404

Closed
matthiaspalmer opened this issue Dec 21, 2017 · 3 comments
Closed
Milestone

Comments

@matthiaspalmer
Copy link
Contributor

matthiaspalmer commented Dec 21, 2017

The problem is simply that the dijit instance is not sent along in the callback and "this" is scoped to the event objects this, i.e. the dom element.
I forked and fixed the problem at Bitbucket as we needed a fix ASAP.

@dylans
Copy link
Contributor

dylans commented Dec 21, 2017

thanks @matthiaspalmer . Do you care to create a PR with the fix?

@matthiaspalmer
Copy link
Contributor Author

Sure, here it is:
#1405

@dylans dylans added this to the 1.2.1 milestone Dec 22, 2017
@dylans
Copy link
Contributor

dylans commented Dec 22, 2017

Thanks! Closed via 7f676bb.

@dylans dylans closed this as completed Dec 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants