Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update chalk #1981

Open
thany opened this issue Nov 22, 2024 · 0 comments
Open

Update chalk #1981

thany opened this issue Nov 22, 2024 · 0 comments
Labels
backlog Issue/PR/discussion is reviewed and added to backlog for the further work 🐞 bug

Comments

@thany
Copy link

thany commented Nov 22, 2024

Describe the Bug

Chalk is out of date. If the main project needs chalk, and installs the latest version (and why wouldn't it) it will break JSS and cause #1980.

Updating chalk is a inoffensive task, and has little to no consquences in terms of code changes.

There's no real reason to stick with an old version of a dependency, especially seeing how it forces the main project to get stuck on that old version as well. This is why it's important that packages people might use, update their depedencies. Not just chalk, but in this case it's causing a real-world issue.

To Reproduce

Install chalk 5.3.0 in any Next.js based JSS project and see how the build explodes.

Expected Behavior

Build doesn't explode?

Possible Fix

Update chalk.

Provide environment information

  • Sitecore Version: 10.4
  • JSS Version: 22.2.1
  • Browser Name and version: Firefox latest
  • Operating System and version (desktop or mobile): desktop, Windows 10
  • Link to your project (if available): N/A
@thany thany added the 🐞 bug label Nov 22, 2024
@art-alexeyenko art-alexeyenko added the backlog Issue/PR/discussion is reviewed and added to backlog for the further work label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Issue/PR/discussion is reviewed and added to backlog for the further work 🐞 bug
Projects
None yet
Development

No branches or pull requests

2 participants