Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isClippedBySize() does not account for cases where the grandparent of a text node fully indents and clips text #731

Closed
1 task done
Jym77 opened this issue Mar 2, 2021 · 1 comment · Fixed by #848
Closed
1 task done

isClippedBySize() does not account for cases where the grandparent of a text node fully indents and clips text #731

Jym77 opened this issue Mar 2, 2021 · 1 comment · Fixed by #848
Assignees
@Jym77
Labels
bug Report of unexpected or faulty behaviour in Alfa

Comments

@Jym77
Copy link
Contributor

Jym77 commented Mar 2, 2021 •
edited by kasperisager
Loading

isClippedBySize() currently returns false for the following text node:

<style>
  div {
    overflow-x: hidden;
    text-indent: 100%;
    white-space: nowrap;
  }
</style>

<div>
  <span>This is invisible</span>
</div>
@Jym77 Jym77 added the bug Report of unexpected or faulty behaviour in Alfa label Mar 2, 2021
@kasperisager kasperisager changed the title isClippedBySize should consider all ancestor when looking for hidden overflow isClippedBySize() does not account for cases where the grandparent of a text node fully indents and clips text Mar 2, 2021
@kasperisager
Copy link
Contributor

Adjusted the title and description to clarify the issue at hand, not the proposed solution. The issue with simply looking further up the tree for a computed overflow-x is that, for some reason, many pages declare overflow-x: hidden near the document root (<body> or <html>).

For lack of a layout system, I'd rather we assume that text-indent: -100% or text-indent: 100%; white-space: nowrap means that the text will be invisible, regardless of overflow-x. There might be other pitfalls to that so let's examine those a little further at a refinement.

@Jym77 Jym77 mentioned this issue Mar 3, 2021
Merged
@Jym77 Jym77 self-assigned this Jul 1, 2021
@Jym77 Jym77 mentioned this issue Jul 1, 2021
Merged
@Jym77 Jym77 closed this as completed in #848 Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jym77 Jym77

Labels
bug Report of unexpected or faulty behaviour in Alfa
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make descendents of fully clipped nodes invisible Siteimprove/alfa
2 participants
@kasperisager @Jym77