Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StyleCop warnings no longer fail the build #1658

Closed
4 tasks done
antonfirsov opened this issue Jun 13, 2021 · 1 comment · Fixed by SixLabors/SharedInfrastructure#20 or #1664
Closed
4 tasks done

StyleCop warnings no longer fail the build #1658

antonfirsov opened this issue Jun 13, 2021 · 1 comment · Fixed by SixLabors/SharedInfrastructure#20 or #1664

Comments

@antonfirsov
Copy link
Member

antonfirsov commented Jun 13, 2021

Prerequisites

  • I have written a descriptive issue title
  • I have verified that I am running the latest version of ImageSharp
  • I have verified if the problem exist in both DEBUG and RELEASE mode
  • I have searched open and closed issues to ensure it has not already been reported

Description

#1632 resulted in merging a couple of build warnings, for example:

FastFloatingPointDCT.cs(66,41): warning SA1306: Field 'C_V_InvSqrt2' should begin with lower-case letter
JpegEncoderCore.cs(72,33): warning SA1201: A field should not follow a property
JpegEncoderCore.cs(183,25): warning SA1101: Prefix local calls with this
...

We used to have some "warning as error" switch on this, looks like it no longer works, so they managed to sneak in through the CI.

@JimBobSquarePants
Copy link
Member

@antonfirsov This is super weird.

There have been no changes to the props files and having just experimented with putting the rule on every possible level with or without the condition I can confirm it simply does not work. I wonder whether something was broken in latest SDK + MSBuild?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants