Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Jpeg Decoder #192

Closed
antonfirsov opened this issue Apr 27, 2017 · 5 comments
Closed

Improve Jpeg Decoder #192

antonfirsov opened this issue Apr 27, 2017 · 5 comments

Comments

@antonfirsov
Copy link
Member

antonfirsov commented Apr 27, 2017

Removed all my previous notes here, because my new investigations outdated them.

This point should be replaced by a WIP PR. (Continuing #274 or open a new one for a clean start.)

I'll try to put my notes here later.

@JimBobSquarePants
Copy link
Member

Here's a list of additional issues related to jpeg that we would like to get help with.

https://github.com/JimBobSquarePants/ImageSharp/issues?q=is%3Aissue+is%3Aopen+label%3Aarea%3Aformats%3Ajpeg

@antonfirsov
Copy link
Member Author

antonfirsov commented May 11, 2017

@firenero thanks for the refactor help you done here!
We still need to implement that MemoryManager to provide more control over the ArrayPool behaviour, but it's not a Jpeg-specific task to implement it.

It would be nice to find people to help with the other (harder) points or the smaller issues from this list!

@firenero
Copy link
Contributor

@antonfirsov np, I'm glad to help!
I'm also going to help you with other things soon (just have a lack of time right now).

@antonfirsov
Copy link
Member Author

antonfirsov commented May 28, 2017

I started to work on the generic compression stuff. See:

My plan is to store the JpegDecoderCore.DecodedBlocks in a CompressedBuffer when PerformanceCharacteristic == LowestMemory and use DummyPackedBuffer otherwise. The same could be done to jpeg image channels later.

@antonfirsov
Copy link
Member Author

Closing this in favor of #298.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants