Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could not load file or assembly System.ValueTuple #270

Closed
4 tasks done
xalikoutis opened this issue Jul 6, 2017 · 6 comments
Closed
4 tasks done

Could not load file or assembly System.ValueTuple #270

xalikoutis opened this issue Jul 6, 2017 · 6 comments

Comments

@xalikoutis
Copy link

xalikoutis commented Jul 6, 2017

Prerequisites

  • I have written a descriptive issue title
  • I have verified that I am running the latest version of ImageSharp
  • I have verified if the problem exist in both DEBUG and RELEASE mode
  • I have searched open and closed issues to ensure it has not already been reported

Description

an error is thrown when the following is called. image is a byte[] and i have installed System.ValueTuple 4.3.1 which imagesharp depends
var input = Image.Load(image)
Error

Could not load file or assembly 'System.ValueTuple, Version=4.0.2.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'. The system cannot find the file specified., Stack=   at ImageSharp.Image.Load[TPixel](Configuration config, Stream stream, IImageFormat& format)
   at ImageSharp.Image.Load[TPixel](Configuration config, Byte[] data)

Steps to Reproduce

var input = Image.Load(image)

System Configuration

windows 10 and also in prod linux docker

  • ImageSharp version: 1.0.0-alpha9-00170
  • Other ImageSharp packages and versions:NA
  • Environment (Operating system, version and so on):windows,linux
  • .NET Framework version: .net core 1.1
  • Additional information:
@xalikoutis
Copy link
Author

update System.ValueTuple to 4.4.0-preview1-25305-02 and everything works fine

@OskarKlintrot
Copy link

Isn't there any other way to solve this than have to use the same version that ImageSharp uses? I don't really want to have to look at ImageSharp source code when updating and make sure I use the same version. This is also forcing me to use a preview version of something I don't want a preview version of.

@JimBobSquarePants
Copy link
Member

Ummmmmm.... ImageSharp is an alpha?! We are using those versions because we need them to build a performant and usable library.

Those previews will cease to be once Netcore 2 is released so I really wouldn't worry.

@OskarKlintrot
Copy link

I know but ImageSharp is forcing me to use other libraries preview versions and I don't want that. And I definitely don't want to look in ImageSharp source code to figure out what is breaking things. I will move to Netcore 2 once it's released so then I don't mind.

@antonfirsov
Copy link
Member

@OskarKlintrot At the time ImageSharp get's RC, these libraries will be in an RC state as well. We are building a future-proof API with the newest netstandard/netcore toys, so this is a reasonable tradeoff. "Being in preview" is a transitive relation, so I don't see any problem with using preview packages in a preview library.

I can only qute the disclaimer from our README.md:

ImageSharp has made excellent progress and contains many great features but is still considered by us to be in early stages (alpha). As such, we cannot support its use on production environments until the library reaches release candidate status.

@OskarKlintrot
Copy link

@JimBobSquarePants already noted it and I'm fine with that! I love new toys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants