-
-
Notifications
You must be signed in to change notification settings - Fork 852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Could not load file or assembly System.ValueTuple #270
Comments
update System.ValueTuple to 4.4.0-preview1-25305-02 and everything works fine |
Isn't there any other way to solve this than have to use the same version that ImageSharp uses? I don't really want to have to look at ImageSharp source code when updating and make sure I use the same version. This is also forcing me to use a preview version of something I don't want a preview version of. |
Ummmmmm.... ImageSharp is an alpha?! We are using those versions because we need them to build a performant and usable library. Those previews will cease to be once Netcore 2 is released so I really wouldn't worry. |
I know but ImageSharp is forcing me to use other libraries preview versions and I don't want that. And I definitely don't want to look in ImageSharp source code to figure out what is breaking things. I will move to Netcore 2 once it's released so then I don't mind. |
@OskarKlintrot At the time ImageSharp get's RC, these libraries will be in an RC state as well. We are building a future-proof API with the newest netstandard/netcore toys, so this is a reasonable tradeoff. "Being in preview" is a transitive relation, so I don't see any problem with using preview packages in a preview library. I can only qute the disclaimer from our README.md:
|
@JimBobSquarePants already noted it and I'm fine with that! I love new toys! |
Prerequisites
DEBUG
andRELEASE
modeDescription
an error is thrown when the following is called. image is a byte[] and i have installed System.ValueTuple 4.3.1 which imagesharp depends
var input = Image.Load(image)
Error
Steps to Reproduce
var input = Image.Load(image)
System Configuration
windows 10 and also in prod linux docker
The text was updated successfully, but these errors were encountered: