Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Expose outputs to Transaction #87

Open
Fonta1n3 opened this issue May 17, 2023 · 3 comments
Open

Feature request: Expose outputs to Transaction #87

Fonta1n3 opened this issue May 17, 2023 · 3 comments

Comments

@Fonta1n3
Copy link
Contributor

It would be useful to be able to access the outputs of a raw transaction like so Transaction("rawtxhex").outputs just as you can access the inputs.

@Sjors
Copy link
Owner

Sjors commented May 17, 2023

I'm somewhat tempted to strip all non-psbt functionality from the library. Do you think you can do what you need with the PSBT methods? Or is something missing here, or even missing in libwally-core?

On the other hand, if you can make a PR and it's simple, that's fine too.

@Fonta1n3
Copy link
Contributor Author

The only reason I am using Transaction is because the library allows me to create a Transaction manually with TxInput and TxOutput, whereas to generate a PSBT I need to pass it a PSBT.

Would be great to initialize a PSBT in a similar way that we initialize a Transaction, by supplying the inputs and outputs.

@Sjors
Copy link
Owner

Sjors commented May 19, 2023

That sounds like a more future-proof approach to me, but no idea how involved it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants