Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_thisEvent magic var false positives #147

Open
mwpowellhtx opened this issue Jan 16, 2024 · 0 comments
Open

_thisEvent magic var false positives #147

mwpowellhtx opened this issue Jan 16, 2024 · 0 comments

Comments

@mwpowellhtx
Copy link

mwpowellhtx commented Jan 16, 2024

_thisEvent indicated as a false positive. By contrast _thisEventHandler did not and did not warn, maybe because the first was the offending token, I do not know.

[_thisEvent, _thisEventHandler] params ["_event", "_ehID"];
// ^^^^^^^^

In the context of an ctrlAddEventHandler use case.

_thisEventHandler does not warn whatsoever, correctly, I think. Tried adding _thisEvent to the sqflint.ignoredVariables settings to no avail, so the case must be deeply rooted in the token parsing, baked into the cake, if you will.

Overall, need the ability to better train the LINT with various situations. It covers 80-90 percent of the common ones, but for gremlins such as this.

Or at least somehow the ability to #define our way around warnings such as these.

Best!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant