Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove values tokens from ´.env_default´ #368

Closed
zhenik opened this issue Oct 2, 2020 · 0 comments · Fixed by #373
Closed

Remove values tokens from ´.env_default´ #368

zhenik opened this issue Oct 2, 2020 · 0 comments · Fixed by #373
Assignees
Labels
stage/help-wanted Extra attention is needed stage/needs-discussion Discussion with other contributors is wanted type/bug Something isn't working
Milestone

Comments

@zhenik
Copy link
Contributor

zhenik commented Oct 2, 2020

We should enforce users to use the correct token explicitly

Why

  • There is no way that production clusters will have token="master" (we downstream that implicitly to each module as env)
  • Default env downstream implicitly -> template -> module
    • Module deployment goes via terraform. Communication (between terraform and consul, nomad, vault) is handled by terraform-providers. In the modules, we handle this part correctly only in nomad_acl

How

Remove these two lines

https://github.com/fredrikhgrelland/vagrant-hashistack/blob/master/ansible/templates/.env_default.j2#L13-L14

VAULT_TOKEN=master
CONSUL_HTTP_TOKEN=master

Affect

  • Test matrix
  • box repo
  • template repo
  • each module (some)

Related issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stage/help-wanted Extra attention is needed stage/needs-discussion Discussion with other contributors is wanted type/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants